Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate accessanalyzer resources to AWS SDK for Go v2 #31156

Merged
merged 9 commits into from
May 4, 2023
Merged

Tech debt: Migrate accessanalyzer resources to AWS SDK for Go v2 #31156

merged 9 commits into from
May 4, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Ibid.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAccessAnalyzer_serial' PKG=accessanalyzer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20  -run=TestAccAccessAnalyzer_serial -timeout 180m
=== RUN   TestAccAccessAnalyzer_serial
=== PAUSE TestAccAccessAnalyzer_serial
=== CONT  TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/tags
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Type_Organization
    acctest.go:895: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/update_filters
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/basic
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/disappears
--- PASS: TestAccAccessAnalyzer_serial (126.32s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (63.52s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/tags (36.53s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (0.31s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (15.29s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (11.38s)
    --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule (62.80s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/update_filters (34.43s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/basic (15.54s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/disappears (12.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	131.595s

@github-actions
Copy link

github-actions bot commented May 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels May 4, 2023
@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 4, 2023
@ewbankkit ewbankkit merged commit 95d1984 into main May 4, 2023
@ewbankkit ewbankkit deleted the td-accessanalyzer-aws-sdk-go-v2 branch May 4, 2023 20:01
@github-actions github-actions bot added this to the v4.66.0 milestone May 4, 2023
github-actions bot pushed a commit that referenced this pull request May 4, 2023
Update CHANGELOG.md for #31156
af4c081
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label May 8, 2023
danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this pull request May 31, 2023
Update CHANGELOG.md for hashicorp#31156
6d92609
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.66.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @justinretzolk